search

dsgibbons / shap

A game theoretic approach to explain the output of any machine learning model.
https://shap-community.readthedocs.io/en/latest/
MIT License
25 stars 5 forks source link

refactor: some minor fixes #65

Closed thatlittleboy closed 1 year ago

thatlittleboy commented 1 year ago

Just knocking out some simple fixes. Should be an easy review.

Typos, and some improvements to tests.

thatlittleboy commented 1 year ago

Tests are failing, not sure why.

dsgibbons commented 1 year ago

The failures are connected to HTTP timeouts as a result of trying to access Hugging Face text models/tokenizers. Maybe Hugging Face was down at the time? Ideally, the unit tests wouldn't depend on having to download external resources. Rerunning tests now.

dsgibbons commented 1 year ago

The tests look better now. Did you want to mark this as ready for review?

thatlittleboy commented 1 year ago

It seems there's still some xgboost errors though (there should only be 2 tests failing, but now there are 4). I'll find time to investigate, today or tmr.