search

dsgibbons / shap

A game theoretic approach to explain the output of any machine learning model.
https://shap-community.readthedocs.io/en/latest/
MIT License
25 stars 5 forks source link

Fix further NumbaDeprecationWarnings: migrate from jit to njit #68

Closed connortann closed 1 year ago

connortann commented 1 year ago

Original issue: https://github.com/slundberg/shap/issues/2909

PR #9 attempted to solve the issue by explicitly specifying nopython=False, but inadvertently introduced other Deprecation warnings as nopython mode is being removed entirely.

The recommendation from numba is to disable the object mode behaviour, by setting nopython=True or equivalently using njit.

connortann commented 1 year ago

On the previous PR, I didn't check that the warnings were fixed on python 3.10. Checking the logs of this PR, those warnings seem to be properly fixed now.

The only Numba warnings that remain relate to deprecated types; I opened a separate issue for that: #70.

connortann commented 1 year ago

@dsgibbons would you be able to review?

The numba warnings seem to be of relatively high interest judging by the traffic, so it would be fab to get this issue fixed fully.