Closed thatlittleboy closed 1 year ago
Merging #87 (388fdda) into master (3213a3b) will increase coverage by
1.13%
. The diff coverage is81.25%
.
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 52.22% 53.36% +1.13%
==========================================
Files 90 90
Lines 13146 13028 -118
==========================================
+ Hits 6866 6952 +86
+ Misses 6280 6076 -204
Impacted Files | Coverage Δ | |
---|---|---|
shap/plots/_violin.py | 75.86% <80.00%> (+54.98%) |
:arrow_up: |
shap/plots/_beeswarm.py | 49.18% <100.00%> (-0.19%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
part of #54 .
violin
plot code quite a bit. The originalviolin
was essentially a copy-paste from thesummary_legacy()
function, so there's a lot of redundant code (including a call to a "non-existent"summary()
function) checking for "bar" or "dot" plot types. These have all been removed. Violin plots don't support multioutputs (only bar plots support this), so that section has been removed as well.violin
is still in the "legacy" style. For e.g., it still acceptsshap_values
as a numpy array. Whereasbeeswarm
only takes inExplanation
objects, which I think we should align to that convention. -> Issue #55.test_violin.py
andtest_summary.py
were revamped. In particular, the original test was just an empty plot...