search

dsgiitr / d2l-pytorch

This project reproduces the book Dive Into Deep Learning (https://d2l.ai/), adapting the code from MXNet into PyTorch.
Apache License 2.0
4.25k stars 1.24k forks source link

12.9_Adadelta.ipynb #77

Closed akshitmittal1 closed 5 years ago

review-notebook-app[bot] commented 5 years ago

Check out this pull request on ReviewNB: https://app.reviewnb.com/dsgiitr/d2l-pytorch/pull/77

You'll be able to see notebook diffs and discuss changes. Powered by ReviewNB.

harshalmittal4 commented 5 years ago

Hi @akshitmittal1, it would be nice if you could squash the commits into maximum of 3-4 as it contains 2 sections, this would help keep track of changes in future. You can check how to squash and then force-push your changes online. Thanks.

akshitmittal1 commented 5 years ago

@harshalmittal4 Actually, I made some commits long back to fix some issues. They are also coming along with the pull request, so I have made a new pull request which only contains 2 commits. Can you please check that?

harshalmittal4 commented 5 years ago

Yes, cool.