dsgkirkby
commented
7 years ago Hmm, I'll investigate the missing position and team. Position might not be fixable, team I might be able to hack something together, but it's so hard to deal with all the various formats that get used in their data that this might be the best we can do.
Re: penalties - fuck, I'm going to have to re-write the strength logic. I'll try to get to that soon.
I've been doing a lot of work with this can, so I've come across a few minor glitches, which is to be expected.
Commas in QMJHL Teams Names
I think I told you about this one before but I probably forgot to make a ticket. The QMJHL team names have commas in between the city and nickname. I don't know why, but this is a Quebec thing, they love this. I don't love it. :) Rather unusually, this only seems to be an issue in the Players output, and not in Games, Goals or Penalties. I have noticed that there are no commas in the Birthplace column, which is odd, which makes me wonder if the program is stripping commas from the wrong column on that output?
Some Players Have No Team
Not sure how this happens, but some players in the Players output don't have a team, or a position for that matter.
It's a rare occurrence - I found just 5 players with missing teams in four seasons of OHL data, and 11 in four seasons of QMJHL data.
Coincidental Penalties
One thing I noticed looking at the 5v5 time was that it appears that you have 5v5 continuing after coincidental penalties. Coincidental penalties when teams are 5v5 actually turn play to 4v4, which would reduce the 5v5 time that is currently being outputted. (If coincidental penalties are taken at non-even strength, the strength stays the same. ie, coincidental penalties at 5v4, situation stays at 5v4, not 4v3).