dsglaser / cis-security

Playbooks to implement Center for Internet Security (CIS) controls for RHEL (7-9), RHEL Clones, Ubuntu (18.04-22.04), and Microsoft Windows (10, Server 2019)
Other
90 stars 63 forks source link

Bugs in redhat-8 section #38

Closed mchandler-wowcorp closed 2 years ago

mchandler-wowcorp commented 2 years ago

The "Add unused_filesystems to /etc/modprobe.d/CIS.conf" task has improperly indented values. The "Wait for AIDE initialization to complete" tasks has an extra colon in the command.

$ diff -u .ansible/collections/ansible_collections/dsglaser/cis_security/roles/cis_security/tasks/type-files/redhat-8-type.yml redhat-8-type.yml > rh8t.patch
$ cat rh8t.patch 
--- .ansible/collections/ansible_collections/dsglaser/cis_security/roles/cis_security/tasks/type-files/redhat-8-type.yml        2022-08-05 02:16:05.128045797 +0000
+++ redhat-8-type.yml   2022-08-05 02:10:19.569043922 +0000
@@ -88,9 +88,9 @@
       line: "install {{ item }} /bin/true"
       state: present
       create: true
-    owner: root
-    group: root
-    mode: 0644
+      owner: root
+      group: root
+      mode: 0644
     with_items:
       - "{{ unused_filesystems }}"

@@ -585,7 +585,7 @@
           - 1.4.1

       - name: Wait for AIDE initialization to complete
-        ansible.builtin.async_status:: jid={{ aide.ansible_job_id }}
+        ansible.builtin.async_status: jid={{ aide.ansible_job_id }}
         register: aide_status
         until: aide_status.finished
         when: ( not aide_path.stat.exists or not aide_path.stat.isreg ) and ansible_distribution != "SLES"
dsglaser commented 2 years ago

Thanks, I appreciate catching it. The fix has been merged into master

mchandler-wowcorp commented 2 years ago

No worries. I'm stoked to have the opportunity to contribute something back to this great project.