search

dshadowwolf / ideas-for-a-new-language

Ideas for a modern cross-paradigm programming language
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

Promised BNF Grammar `import`/`imports` Statement Fixes #2

Closed RandomDSdevel closed 7 years ago

RandomDSdevel commented 7 years ago

Here are the fixes I proposed in this comment on commit abc6933 a while back. Note, however, that they are slightly different from what I originally suggested since I noticed a problem with respect to recursively in my initial attempt.

RandomDSdevel commented 7 years ago

OK, now why did that second commit show up in this PR? I was going to wait to submit that one in a separate PR….

RandomDSdevel commented 7 years ago

@dshadowwolf (from commit 47bdc13's commit message:)

It likely showed up because you had it as a following commit[ — ]when you submit a PR, you submit all the changes cued in that branch[.]

Ah, right; that's probably what did it, then. I guess I should have remembered to stage those two commits on separate branches. Well, that's something to try and remember, at least! (And you'd think I would, too, since I've done branch-based development when submitting PRs to Homebrew — well, Homebrew Core, really, since I've only fixed formula issues there and not implementation ones — before. 😆)