search

dshafik / haos-addon-scrypted

MIT License
2 stars 0 forks source link

host networking is disabled on addon #2

Open thomas-svrts opened 1 year ago

thomas-svrts commented 1 year ago

using your addon causes that host networking is disabled. You can't use homekit plugin of Scrypted without the ports opened on the container

I guess you need to add. host_network: true in the yaml file

dshafik commented 1 year ago

Ah, I didn't confirm it was working with HomeKit from my test HA instance, so I didn't catch this. If you would like, you can open a PR very easily yourself with this change: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

Otherwise I'll try to get to it this evening.

Thanks for the report!

dshafik commented 1 year ago

@thomas-svrts I have pushed out a new release for v0.3.7.lite and added the host_network: true option to the YAML. Can you please confirm that this fixes your issue?

thomas-svrts commented 1 year ago

Now it works. But you may also remove the ports config section now. If you use host network, port mapping is ignored.

See also repos like this: https://github.com/ggravlingen/ha-addon-scrypted/

He also had the ingress working…

thomas-svrts commented 1 year ago

And here is also another Scrypted addon for ha: https://github.com/aegjoyce/ha-addons/tree/main/scrypted

dshafik commented 1 year ago

I figured I would have to remove the ports but didn't want to do so without testing.

It looks like ggravlingen/ha-addon-scrypted has solved the ingress problem similarly to how I was thinking to do it — however it still requires separate authentication. I'm considering ways of forwarding the authentication automatically.

Having said that, I will play around with that one and if it allows ingress at all I'll likely switch to contributing to that repo (or if I maintained I'll fork it).

Thanks for the confirmation!

thomas-svrts commented 1 year ago

Having said that, I will play around with that one and if it allows ingress at all I'll likely switch to contributing to that repo (or if I maintained I'll fork it).

Good idea. Please be noted that he said he will delete/archive his repo later this year: https://community.home-assistant.io/t/add-on-scrypted-homekit-secure-video/398487/30?u=thomas-svrts