dshanske / bridgy-publish

Bridgy for WordPress ( Functionality now in Syndication Links Plugin. This is being deprecated)
https://wordpress.org/plugins/bridgy-publish
8 stars 6 forks source link

Wordpress error - Warning: stripos() expects parameter 1 #19

Closed davidmead closed 7 years ago

davidmead commented 7 years ago

Installed the updated version. Having it default to Twitter works great. Thanks.

I have noticed this error on my pages where something has been syndicated to Twitter though

Warning: stripos() expects parameter 1 to be string, array given in /nfs/c03/h06/mnt/56448/domains/davidjohnmead.com/html/blog/wp-includes/formatting.php on line 3774

david_john_mead___living_and_working_on_the_web__with_a_british_point_of_view

Looking at that file it's to do with checking & cleaning URL's. Not sure if this to do with this plugin, but it only appeared after I updated.

Here's the settings for the plugin currently.

screenshot 2017-01-21 09 22 24
dshanske commented 7 years ago

I will try to reproduce the error on my sites. How is the update otherwise?

davidmead commented 7 years ago

Looks good so far @dshanske. Everything working as expected 👍

dshanske commented 7 years ago

I have the same error in my logs, but from November, so it must be something else. Might be a multi plugin interaction.

miklb commented 7 years ago

I'm seeing the error in my logs that coincide with my last published post attempting to post to bridgy, fwiw.

dshanske commented 7 years ago

It is hard to trace because it doesn't reference a plugin file, but I will keep trying.

dshanske commented 7 years ago

stripos only appears in the file in question in esc_url

dshanske commented 7 years ago

Which is not called by this plugin, but is called by Syndication Links, which this plugin does set display parameters for. May need a check for empty in that plugin

davidmead commented 7 years ago

The only other plugin that updated recently, that I have installed, is JetPack. That was 4 days ago. Not sure if that would effect it.

dshanske commented 7 years ago

Do you have Syndication Links installed?

miklb commented 7 years ago

@dshanske I have syndication links installed.

davidmead commented 7 years ago

Yes. Version 3.0.5

dshanske commented 7 years ago

It is the combination of the two

davidmead commented 7 years ago

Just installed your update @dshanske. No error messages on my blog page now when publishing and syndicating to Twitter. The posts with the original error, still shows it.

Did notice that that when the post is published on Twitter, the syndication link is not showing.

image

dshanske commented 7 years ago

Do you want it to?

davidmead commented 7 years ago

Yes. It used to before the update and I'd like to keep that if possible.

See https://twitter.com/davidmead/status/822630405987823616 as an example.

image

dshanske commented 7 years ago

Odd. It is showing on mine. It takes about ten seconds after the post. Uses wp-cron. I will have a look after Syndication Links is updated.

davidmead commented 7 years ago

On my blog, yes it shows after the cron. I'm talking about the link back to my post on Twitter.

dshanske commented 7 years ago

What is the omit link parameter set to by default and in the post?

davidmead commented 7 years ago

Omit back link is set to 'Never'

davidmead commented 7 years ago

Hi @dshanske. Just wondered if you had any news on this?

dshanske commented 7 years ago

Not yet. Looking at Syndication Links right now. Will be circling back in a few days to fix some reported bugs on my other improvements

davidmead commented 7 years ago

Cool. Thanks for the update :-)

dshanske commented 7 years ago

I made some changes. Distributing a stable release shortly. Should address.