search

dshanske / bridgy-publish

Bridgy for WordPress ( Functionality now in Syndication Links Plugin. This is being deprecated)
https://wordpress.org/plugins/bridgy-publish
8 stars 6 forks source link

surface errors from bridgy to user #21

Closed snarfed closed 6 years ago

snarfed commented 7 years ago

based on this ongoing conversation with cdevroe: https://chat.indieweb.org/2017-01-25/1485372011628000

... it sounds like errors from bridgy, ie non -2xx responses and their bodies, are currently dropped on the floor and nor shown to the user. it'd be nice to show them at some point. :P

specifically the error here from attempting to publish :

Couldn't find link to brid.gy/publish/twitter

log: https://brid.gy/log?start_time=1485371674&key=aglzfmJyaWQtZ3lyOgsSDVB1Ymxpc2hlZFBhZ2UiE2h0dHA6Ly9jZGV2cm9lLmNvbS8MCxIHUHVibGlzaBiAgICAgICACgw

docs: https://brid.gy/about#webmentions

(btw, the plugin should probably add this link itself if necessary, right?)

i hate to say it, but the easiest way to surface errors is probably to switch from async cron to synchronous, so you have the response and can show it to the user right then.

thanks again for all your work on this plugin!

snarfed commented 7 years ago

looks like the same thing happened to @cdevroe on facebook:

https://brid.gy/facebook/10158195666450370#publishes

https://brid.gy/log?start_time=1485371678&key=aglzfmJyaWQtZ3lyOgsSDVB1Ymxpc2hlZFBhZ2UiE2h0dHA6Ly9jZGV2cm9lLmNvbS8MCxIHUHVibGlzaBiAgICAgOSRCgw

dshanske commented 7 years ago

I just switched to async, partly because of an odd other issue. But I think I can take a page from SNAP on how they handle it. In the last update, the error is returned, but not acted on.

dshanske commented 7 years ago

I think I have to figure out how the link is not going when the Webmention is. I never could reproduce in testing

dshanske commented 7 years ago

I think I have to figure out how the link is not going when the Webmention is. I never could reproduce in testing

dshanske commented 7 years ago

And @snarfed, the plugin is merely a UI for the wonderful service you built and maintain.

snarfed commented 7 years ago

thanks for the kind words!

i have a fair amount of experience with async vs sync, and honestly, the code and UX will both be much simpler and better if you go back to sync. it will cost a second or two in latency per publish, but i'm pretty sure it'll be worth it in this case. just my 2¢.

dshanske commented 7 years ago

Actually I did it partially because the setting of the manual fill in for mf2_syndication kept conflicting with the automatic one from the Webmention. Other ways to solve it.

dshanske commented 7 years ago

Deploying a fix for this shortly.

snarfed commented 6 years ago

more complaints about this: https://chat.indieweb.org/2018-01-09#t1515524954448400

dshanske commented 6 years ago

I think I have fixed this in the latest version.