search

dshanske / indieweb-post-kinds

adds support for responding to and interacting with other sites using the standards developed by the Indieweb Community
https://wordpress.org/plugins/indieweb-post-kinds/
Other
44 stars 28 forks source link

Post Kinds auto sets Post Format and doesn't allow change #86

Open chrisaldrich opened 7 years ago

chrisaldrich commented 7 years ago

Reminder from indieweb chat: https://chat.indieweb.org/2017-04-08/1491695804216000

I noticed in the recent update to Post Kinds, you're autosetting the post format based on kind, but don't give the user the chance to modify it after the fact. (Or doing so doesn't seem to do anything as it gets set back to the original on update.)

This may be quirky for some themes which don't include author details for asides (or add titles) when posting a note, while it may be more germane to use something like status.

I think most of them map pretty well (or are at least one to one), but there may be cases people want to change it after the initial post.

dshanske commented 7 years ago

It will no longer trigger this on update.

chrisaldrich commented 7 years ago

Something may have gone sideways when you updated this?

According to @tamaracks in https://github.com/snarfed/wordpress-micropub/issues/56#issuecomment-300540804 when setting a Post Kind, it's not automatically setting the Post Format immediately upon publish.

I've tested this out myself using the latest Post Kinds and current version of WordPress and am seeing the same thing. Particularly when posting a note kind, it isn't setting the format to aside as expected (or previously seen in the prior version).

Simultaneously this came out of some discussion (from the same thread above), that micropub clients like OwnYourSwarm or OwnYourGram aren't setting the Post Kind to checkin automatically. (Which is a separate, but somewhat related bug.)

tamaracks commented 7 years ago

Oh, good, so it's not just me? Thanks for testing that, @chrisaldrich!

tamaracks commented 7 years ago

@dshanske If @chrisaldrich is seeing the same thing I am where the Post Format is not being set at all by Post Kinds, should this issue be reopened or should it be a new issue?

chrisaldrich commented 7 years ago

This bug mentioned in the micro.blog slack also makes it sound like posts coming in via micropub or other methods aren't automatically setting the post kind, which may be related to this issue: https://microblogging.slack.com/archives/C422USPPT/p1494879500056086

dshanske commented 7 years ago

I was asked to amend the auto setting behavior because it wasn't letting people override. I fear I may have introduced this as a result. Will investigate.

interllectual commented 6 years ago

I am having this same issue-- seems like post format is not set at all by post kinds, and just uses my default format. When posting via Quill, both the kind and the format are selected.

dshanske commented 6 years ago

I need to revisit this. @interllectual can you provide more details? Specifically what kind are you creating and what format are you expecting?