dshanske / indieweb-publisher

Fork of Independent Publisher with Backported Fixes and Better Indieweb Compatibility (Still under development))
GNU General Public License v3.0
19 stars 4 forks source link

Single-column mode not working #14

Open jackjamieson2 opened 5 years ago

jackjamieson2 commented 5 years ago

Maybe related to #13

If I'm understanding correctly, indieweb-publisher uses a universal indieweb_publisher_option() function to check each option from the customizer

This replaces multiple functions that indepenent publisher has for each option . e.g. independent_publisher_use_single_column_layout()

The problem is that indieweb_publisher_option only checks one option: "indieweb_publisher_general_options"

But some of the theme settings are saved in other options:

Two solution ideas:

  1. Merge all of the options into one field, either "indieweb_publisher_general_options" or simple "indieweb_publisher_options".
    Pros: Simple Cons: Potential for confusion if pulling in updates from independent publisher

  2. Create three functions to capture all three fields

    • indieweb_publisher_general_option
    • indieweb_publisher_excerpt_option
    • indieweb_publisher_layout_option

Each of these functions could check a specific option field. Pros: Maintain consistence with independent publisher Cons: A bit more work. Loses some of the clarity of single function solution