dshanske / iw26

IW26 is an Indieweb Fork of WordPress Twenty Sixteen Theme
29 stars 3 forks source link

Add optional title to all post kinds #5

Open jgmac1106 opened 6 years ago

jgmac1106 commented 6 years ago

I would add

Title

to the h-entry after the article id if the post has a title.

 
dshanske commented 6 years ago

An explicit title is not part of many post types

jgmac1106 commented 6 years ago

Okay I will look at syndication then. I haven't tried this theme but I don't want to see 2501 if I send a post to Linked in or Twitter. Haven't tried yet.

But also why not give the user the option of titling any post kinds? Aren't heading tags better for accessibility purposes in general or do those readers recognize that certain entries do not use headers?

So a filter to add to it if present when a post updates?

jgmac1106 commented 6 years ago

NVM i see you took care of accessibility already: screen-reader-text ::smile::

jgmac1106 commented 6 years ago

Though in Quotes the title is removed unless you click on the post permalink. In notes it is converted to a paragraph element and included.

I was going to try and style my own titles on post kinds but really can't.

I do see this, "What gets a Title and What Doesn't Get a Title " is a conversation that goes through many iterations across our theme repos.

So feel free to close.

jgmac1106 commented 6 years ago

@dshanske @chrisaldrich I created a spreadsheet to track title behavior when syndicating to Twitter. If you could go through and just mark if you think a user should use a title put a Y or N:

https://docs.google.com/spreadsheets/d/19l28iCNAcMiwL2Tpko0GhiLVAVyl9DPltNS8ZvumwoE/edit?usp=sharing

herestomwiththeweather commented 6 years ago

this may be a dumb question but is there a way to restore the entry-title child element of entry-header for each article?

dshanske commented 6 years ago

What are you trying to accomplish though?

herestomwiththeweather commented 6 years ago

thanks for the reply. i added the theme to https://effaustin.org so that they could accept webmentions with twenty-sixteen but they realized the titles disappeared and consider it an issue.

dshanske commented 6 years ago

In my fork, titles appear based on whether it is an article or not.

dshanske commented 6 years ago

So, it is changeable.

herestomwiththeweather commented 6 years ago

oh! thanks! i will look into that!

herestomwiththeweather commented 6 years ago

i have verified that this works on a different test installation. unfortunately, the expected radio buttons under "Kinds" to select a post kind are absent on the target site (perhaps conflicting with a "Post Attributes" section which does not exist on the test site that succeeded).

herestomwiththeweather commented 6 years ago

following up for posterity sake...it seems the problem i described in previous post may have been related to a page builder plugin. after removing post types/post attributes associated with it and uninstalling and reinstalling post kinds plugin, the post kinds radio buttons appeared. however, even though the Article radio button is the default option for each existing post, it seems i have to edit each legacy post and click its Update button for the Article post kind to become associated with it. also, reactivation of the page builder plugin with its post types does not make the post kinds disappear again. thanks again for help and the excellent indieweb friendly theme.