search

dshanske / simple-location

Adds Basic Location Support to Wordpress
https://wordpress.org/plugins/simple-location
Other
29 stars 14 forks source link

Feature request: static maps #97

Open asuh opened 5 years ago

asuh commented 5 years ago

Considering that embedding maps usually comes with API limits when serving the image from the external service, it would be smart to cache and serve the screenshot image locally: at least default to a locally cached image with the option to continue using an image from external service.

dshanske commented 5 years ago

Would love to, but it is technically a violation of everyone's terms of service

asuh commented 5 years ago

I remember now where I got this idea: https://aaronparecki.com/2018/12/28/17/

dshanske commented 5 years ago

I would seriously love to. But I need some expertise on the TOS concerns or a provider that allows it

dshanske commented 5 years ago

For example, https://developers.google.com/maps/faq?csw=1#tos_staticmaps_reuse

dshanske commented 5 years ago

I just added wikimedia maps. Their terms of use allow caching, so I'll look into building it in future, but only for that provider.

dshanske commented 4 years ago

@asuh Sorry, Wikimedia Maps is gone. Back to TOS issues

asuh commented 4 years ago

I prompted a discussion in the #wordpress channel: https://chat.indieweb.org/wordpress/2020-07-05/1593926551933300

It seems like it might be reasonable to use an API service of some kind with the plugin. Two options discussed:

  1. https://github.com/aaronpk/Static-Maps-API-PHP
  2. https://github.com/katydecorah/staticmapmaker

One route could be integrate the service into the plugin and generate the map image from within the plugin, another would be to host the service in another place and have Simple Location use that service to do the generation for the plugin.

dshanske commented 4 years ago

@asuh Support for #1 is integrated and I'll write a post on how to configure my fork of the Static Maps API using Nginx to do long term caching.