Remove dependency on <algorithm> by introducing nda::internal::{min, max}

dsharlet / array

C++ multidimensional arrays in the spirit of the STL

Apache License 2.0

198 stars 15 forks source link

Remove dependency on <algorithm> by introducing nda::internal::{min, max} #62

Closed fbleibel-g closed 2 years ago

fbleibel-g commented 2 years ago

I replaced std::min with internal::min (where not already in 'namespace internal'). I'm not sure how to trigger Travis CI prior to submitting for review the PR, so I'll wait for travis to complete.

dsharlet commented 2 years ago

Thanks for doing this! It looks good, but there is one small issue: I already merged your PR to add the <algorithm> include. Can you merge master, and remove that include in this PR?

dsharlet commented 2 years ago

BTW, if you want to run the travis build manually, it is here: https://github.com/dsharlet/array/blob/master/.travis.yml#L12-L16. Personally, I only run make test for most work unless I have a particular reason to want the extra test coverage.

fbleibel-g commented 2 years ago

Of course, no problem. I have rebased on HEAD and the change now removes - good catch.