search

dsharlet / array

C++ multidimensional arrays in the spirit of the STL
Apache License 2.0
198 stars 15 forks source link

reinterpret_shape doesn't resolve bare shape #72

Closed linht122 closed 2 years ago

linht122 commented 2 years ago

and results in assertion failure if user provides a bare shape.

dsharlet commented 2 years ago

Can you clarify what you mean by "bare shape", and also share the particular shape types?

linht122 commented 2 years ago

A bare Shape I mean its strides are unknown. It happens when we define the shape directly like this nda::shape<nda::dense_dim<>, nda::dim<>, nda::dim<>> test_shape({100, 100, 1}).

dsharlet commented 2 years ago

I see the problem, this should be fixed now. Thanks for reporting the issue!