dsharlet / array

C++ multidimensional arrays in the spirit of the STL
Apache License 2.0
198 stars 15 forks source link

Adds Abseil Stringify support to nda::interval. #81

Closed jiawen closed 1 year ago

jiawen commented 1 year ago
jiawen commented 1 year ago

@dsharlet Why can't I add @fbleibel-g as a reviewer?

jiawen commented 1 year ago

I think this is missing a new header?

I really despise git at this point.

jiawen commented 1 year ago

I need to change Makefile (or move files around) to ignore test/absl.cpp

dsharlet commented 1 year ago

I need to change Makefile (or move files around) to ignore test/absl.cpp

Maybe there should be a separate folder that contains all of the absl dependent code in it? Maybe that part wouldn't even have a Makefile, if we expect bazel and absl usage to go together?

jiawen commented 1 year ago

I need to change Makefile (or move files around) to ignore test/absl.cpp

Maybe there should be a separate folder that contains all of the absl dependent code in it? Maybe that part wouldn't even have a Makefile, if we expect bazel and absl usage to go together?

I like that. I'll just call it absl and call it absl.h. Then in addition to AbslStringify, I'm tempted to try AbslHashValue (https://abseil.io/docs/cpp/guides/hash)

dsharlet commented 1 year ago

I added @fbleibel-g as a collaborator, maybe that’s what is needed to add him as a reviewer