search

dshawul / Scorpio

Scorpio chess engine
Other
84 stars 18 forks source link

replaced MIN MAX defines by template #22

Closed RichardPortelli closed 2 years ago

RichardPortelli commented 3 years ago

Hello Daniel, I hope I didn't forget anything ;) Thanks

dshawul commented 3 years ago

Thanks,It looks good to me! Maybe we can replace MAX_SCORPIO with something that is shorter like MAXT or something ?

RichardPortelli commented 3 years ago

Thanks,It looks good to me! Maybe we can replace MAX_SCORPIO with something that is shorter like MAXT or something ?

Yes of course :) Usually I prefer to give really explicit names but it's completely fine ;)

dshawul commented 3 years ago

Ok we can keep MAX_SCORPIO :) It looks like the workflow fun is failing -- apparently the template type checking is too strong and prevents MAX between an integer and enum type.

RichardPortelli commented 3 years ago

Damn sorry I forgot these casts : image

RichardPortelli commented 3 years ago

Now it compiles but then there is a segmentation fault?

dshawul commented 3 years ago

Now it compiles but then there is a segmentation fault?

Check the comment I made regaring MAX and MIN being switched.

RichardPortelli commented 3 years ago

Now it compiles but then there is a segmentation fault?

Check the comment I made regaring MAX and MIN being switched.

THe only comment I see is this one "Ok we can keep MAX_SCORPIO :) It looks like the workflow fun is failing -- apparently the template type checking is too strong and prevents MAX between an integer and enum type."