dshean / demcoreg

Utilities for DEM and point cloud co-registration
MIT License
110 stars 42 forks source link

Dem_mask and dem_align glaciers mask not working. #48

Closed HBasiuk closed 2 years ago

HBasiuk commented 2 years ago

Hi there,

I have been trying to use the glacier mask to run the DEM co-registration. When I run it with mask_list in dem_align it doesn't register that I put "glaciers". When I run it in dem_mask I can see that the rgi data set is not being access, I fixed the datadir issue but the MD5 check sum is failing. So the merging and the rest of the get_rgi.sh functionality is lost.

The DM5 checksum that can be downloaded from the GLIMS site is 9ddfdfe9e65c9550bdb8c5c98c4e1aff 00_rgi60.zip

The one being used in the get_rgi.sh code is Check MD5 sum

95bd0486301073bbbe26988303fdaa1d 00_rgi60.zip

orig_zip_md5=95bd0486301073bbbe26988303fdaa1d

I get this error when I run get_rgi.sh: MD5 checksum failed for rgi60.zip: Expected: 95bd0486301073bbbe26988303fdaa1d Downloaded: 9ddfdfe9e65c9550bdb8c5c98c4e1aff

Is this what is causing the issues with running the glaciers mask? How do I fix this?

Thanks in advance.

dshean commented 2 years ago

Thanks for the report @HBasiuk! Looks like the RGI60 zip file was updated. I modified the checksum hardcoded in the get_rgi.sh script, and verified that it works.
https://github.com/dshean/demcoreg/commit/48c2fd62758e3d57efff797c401359206052fb16