dsheiko / nw-autoupdater

⛔️ [DEPRECATED] Library provides low-level API to control NW.js app auto-updates
MIT License
75 stars 36 forks source link

Ability to add custom function for version compare #11

Closed Arti3DPlayer closed 7 years ago

Arti3DPlayer commented 7 years ago

I have a version that looks like: "version": "0.256.00", and your lib says me that i have incorrect version... It will be cool to improve compare:

http://stackoverflow.com/a/6832721/11236

or add ability to use custom function

dsheiko commented 7 years ago

A bit unusual request. I'm using official npm module SEMVER https://github.com/npm/node-semver

semver.gt( remoteManifest.version, this.manifest.version )

It's kinda de facto standard. But ok, why not. I'm going to think about

Arti3DPlayer commented 7 years ago

I don't know why all use semver library if it is better just use own function on 30 lines and remove dependency :)

dsheiko commented 7 years ago

Because it's a standard with clear specification, meaning I can rely on it. I guess we can close this one.