dsherret / dax

Cross-platform shell tools for Deno and Node.js inspired by zx.
MIT License
1.05k stars 35 forks source link

feat: add `rm` command #29

Closed sigmaSd closed 1 year ago

sigmaSd commented 1 year ago

I'm not sure how to fix the formatting I tried to use dprint --config but it still the same thing

Deno.remove folds force and recursive into one option recursive, is it ok to expose only --recursive ?

sigmaSd commented 1 year ago

I noticed that there is a different algorithm for parsing here https://github.com/denoland/deno_task_shell/blob/2ade977cbe14402376b56f6c929adaf07de8b27d/src/shell/commands/args.rs#L76

Is it better to try to faithufull port [rust remove command](https://github.com/denoland/deno_task_shell/blob/2ade977cbe14402376b56f6c929adaf07de8b27d/src/shell/commands/rm.rs ? (which I just noticed xD)

sigmaSd commented 1 year ago

Ok I ended up porting the rust code

These questions remain though

I'm not sure how to fix the formatting I tried to use dprint --config but it still the same thing Deno.remove folds force and recursive into one option recursive, is it ok to expose only --recursive ?

sigmaSd commented 1 year ago

Thanks for picking up the pr @dsherret

Do you think is there a way to avoid duplication between this and the rust crate ? I understand wasm can't do IO (without something like wasi) but what about parsing, maybe in this example instead of porting parse_remove_argumens, I should wasm export it ?