feat: support for custom commands

pocketken commented 2 years ago

As mentioned in #7, it'd be nice to extend the shell parser to be able to handle additional commands as though they were built-ins/in the system path. Here's a quick take at implementing support by means of extending the CommandBuilder with a handle() method for registering a custom command handler/callback. This should fit in nicely with the custom builder pattern outlined in the documentation.

PR is not so much WIP as at a point where I could use some feedback:

does this fit with the direction you want things to go? I tried to be somewhat "non-invasive" in terms of how I implemented this, but as its a new project you may have already had ideas on how you wanted to implement this sort of thing down the road.
not sure I like handle, but command() is obviously taken and customCommand() didn't feel right either.
if you've got a few commands, one at a time would be tedious. Maybe just take a Record<string, CustomCommandHandler>?

pocketken commented 2 years ago

@dsherret hmm; I am getting different behavior when I run this locally in Windows. Both the original and modified version pass here, which now that I think about it noThrow() would in fact, not throw...

I need another coffee.

dsherret commented 2 years ago

It's probably finding a cd command on mac (via resolveCommand)

pocketken commented 2 years ago

It's probably finding a cd command on mac (via resolveCommand)

Of course it is! ..fires up mac..

$ which cd
/usr/bin/cd
$ which echo
/bin/echo
$ which export
$

export wins! I'll update.

pocketken commented 2 years ago

👍 no problem, glad to contribute back where I can.

Thanks again for throwing this together!

dsherret commented 2 years ago

Thanks again for this and all your other PRs! I released version 0.8.0.

dsherret / dax

feat: support for custom commands #8