dsherret / ts-nameof

nameof in TypeScript
MIT License
492 stars 23 forks source link

Recommend to Migrate to `@typescript-nameof` Packages #124

Open manuth opened 1 year ago

manuth commented 1 year ago

Hi @dsherret Only minutes ago, I published a fork of your project called @typescript-nameof/nameof and @typescript-nameof/babel respectively:

https://github.com/typescript-nameof/nameof

I'd be delighted if you could hint to migrate to this project in your most recent issue that is referenced in your README file.

Thank you so much for your great work!

celluj34 commented 1 year ago

@manuth Sorry to bother you on this unrelated issue, but issues aren't enabled on your fork.

I am getting a lot of warnings in the console about duplicate types:

node_modules/@types/jasmine/index.d.ts:31:18 - error TS2300: Duplicate identifier 'describe'.

31 declare function describe(description: string, specDefinitions: () => void): void;
                    ~~~~~~~~

  node_modules/@types/mocha/index.d.ts:2684:13
    2684 declare var describe: Mocha.SuiteFunction;
                     ~~~~~~~~
    'describe' was also declared here.

node_modules/@types/jasmine/index.d.ts:45:18 - error TS2300: Duplicate identifier 'xdescribe'.

45 declare function xdescribe(description: string, specDefinitions: () => void): void;
                    ~~~~~~~~~

  node_modules/@types/mocha/index.d.ts:2705:13
    2705 declare var xdescribe: Mocha.PendingSuiteFunction;
                     ~~~~~~~~~
    'xdescribe' was also declared here.

node_modules/@types/jasmine/index.d.ts:54:18 - error TS2300: Duplicate identifier 'it'.

54 declare function it(expectation: string, assertion?: jasmine.ImplementationCallback, timeout?: number): void;
                    ~~

  node_modules/@types/mocha/index.d.ts:2719:13
    2719 declare var it: Mocha.TestFunction;
                     ~~
    'it' was also declared here.

I do see in my package-lock that mocha was added, but that shouldn't affect my project since it should be a dev dependency of yours. They are only warnings, not errors, so they don't stop anything, but they are annoying. Do you have any advice on how I should fix it?

manuth commented 1 year ago

I'm terribly sorry for the inconvenience, I accidentally had @types/mocha in the dependency tree - I'll go fix it and push a new version

manuth commented 1 year ago

New version is published now! Thank you for your patience

Also, I filed a ticket to the GitHub support to convert the fork to a standalone repository.

As soon as this is taken care of, issues should be available as far as I understand.

//Edit: Oh lol, that was fast! My repository is now standalone and able to accept issues!