dshipper / Tigger

a beautifully simple, command-line based task management system that lives inside your git repo.
http://tiggerlovesdevs.com
Other
41 stars 6 forks source link

Weird Multiple Finished Tasks at Once #13

Closed theonewolf closed 13 years ago

theonewolf commented 13 years ago

No idea what cause it, willing to debug on the weekend:

git commit -am 'finished print [] for each folder' Running tigger.... Matching tasks and commit messages. Completed task: print file paths with SHA1. Completed task: print file paths with SHA1. Completed task: print [] for each folder. Completed task: print [] for each folder. [master 812dc79] finished print [] for each folder 2 files changed, 2 insertions(+), 2 deletions(-)

Odd how it duplicated completed tasks, and also that one task finishing wasn't part of the commit message?

dshipper commented 13 years ago

Ok so basically if you have two commits with the same name Tigger will mark the task as completed twice. So let's say two days ago you had a commit called "test commit." Now let's say today you add a task called "test commit," you finished that task and then you commit with "test commit" Tigger will find both commit messages and mark the task off twice. Effectively there's no negative result, but it's annoying and confusing. I think maybe we should change the for loop in the Ruby code so that it doesn't go through every commit message but just looks at the most recent one. I can do this.

dshipper commented 13 years ago

Fixed.

theonewolf commented 13 years ago

Fixed.

Awesome! Thanks!