dshoreman / servidor

A modern web application for managing servers
GNU Lesser General Public License v2.1
9 stars 11 forks source link

Improve scroll bars in the file editor #190

Open dshoreman opened 4 years ago

dshoreman commented 4 years ago

There's nothing wrong with the default browser scrollbars, but they're not the most attractive either.

Using the Simple Scrollbar addon for CodeMirror, we should set the scrollbarStyle option to 'overlay' to get some better looking bars. This can be further tweaked by setting some custom CSS that's more inline with both the light and dark themes.

Other Addons Worth Implementing

stoppert commented 3 years ago

I created https://github.com/dshoreman/servidor/pull/287 for this

dshoreman commented 3 years ago

I created #287 for this

Merged, thanks!

* search/jumptoline wouldnt work for me (Alt+G opens the Firefox Search for me?)

I get LastPass' "Generate password" page opening when I press Alt+G, and the find bar pops up with Ctrl+G which seems to be bound to "Find next"...

What're the common bindings used in most editors? I've got Ctrl+G setup in vim similar to ctrlp in sublime, (but searching content not filenames). "Jump to line 13" in vim is literally 13G, but that's probably difficult in CodeMirror without the vi mode stuff and isn't really intuitive to non-vim users either.

* fold/foldgutter didnt show any gutters but not any error either

I saw something about the gutters while I was reading through some bits earlier, so that could explain them not showing up. Iirc it adds classes to the gutters but doesn't style them by default, which seems a bit odd but there ya go! I'll have a play later and see if I can find anything