dshoreman / servidor

A modern web application for managing servers
GNU Lesser General Public License v2.1
9 stars 11 forks source link

Fix steps not being added on project creation #568

Closed dshoreman closed 1 year ago

dshoreman commented 1 year ago

When saving a new project with an application of some sort (not a redirect), many of the events won't have their step added despite the event itself still being sent through Pusher.

This updates the affected "jobs" to trigger the start progress event, which gives the progress modal a bit of a kick up the rear, and also updates modal to show steps sooner and with more reliable progress.

codecov[bot] commented 1 year ago

Codecov Report

Merging #568 (e14955f) into develop (75efd94) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             develop     #568   +/-   ##
==========================================
  Coverage      99.77%   99.77%           
- Complexity       455      462    +7     
==========================================
  Files             95       96    +1     
  Lines           1327     1350   +23     
==========================================
+ Hits            1324     1347   +23     
  Misses             3        3           
Impacted Files Coverage Δ
app/Projects/Applications/ApplyAppNginxConfig.php 100.00% <100.00%> (ø)
app/Projects/Applications/CreateSystemUser.php 100.00% <100.00%> (ø)
app/Projects/Applications/DeployApp.php 100.00% <100.00%> (ø)
app/Projects/Applications/PrepareSsl.php 100.00% <100.00%> (ø)
app/Projects/CalculateSteps.php 100.00% <100.00%> (ø)
app/Projects/ReloadNginxService.php 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more