dshoreman / servidor

A modern web application for managing servers
GNU Lesser General Public License v2.1
9 stars 11 forks source link

Bump phpstan up to using level 6 rules #573

Closed dshoreman closed 1 year ago

dshoreman commented 1 year ago

Resolves some ~240 errors mostly with missing return/param hints or missing array key/value typings. Phan seems to support an increasingly limited amount of detection/parsing; suppressing so much is cumbersome.

codecov[bot] commented 1 year ago

Codecov Report

Merging #573 (10fe6e8) into develop (17b19e6) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             develop     #573   +/-   ##
==========================================
  Coverage      99.69%   99.69%           
  Complexity       451      451           
==========================================
  Files             88       88           
  Lines           1325     1329    +4     
==========================================
+ Hits            1321     1325    +4     
  Misses             4        4           
Impacted Files Coverage Δ
app/Databases/DatabaseData.php 100.00% <ø> (ø)
app/Databases/DatabaseManager.php 100.00% <ø> (ø)
app/Databases/TableData.php 100.00% <ø> (ø)
app/FileManager/FileManager.php 97.34% <ø> (ø)
app/Http/Controllers/Auth/Register.php 100.00% <ø> (ø)
app/Http/Requests/CreateProjectRequest.php 100.00% <ø> (ø)
app/Http/Requests/Databases/NewDatabase.php 100.00% <ø> (ø)
app/Http/Requests/FileManager/EditFile.php 100.00% <ø> (ø)
app/Http/Requests/System/SaveGroup.php 100.00% <ø> (ø)
app/Http/Requests/System/SaveUser.php 100.00% <ø> (ø)
... and 26 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more