dshorthouse / SimpleMappr

MapServer and PHP-MapScript application to create publication-quality maps
http://www.simplemappr.net
MIT License
28 stars 2 forks source link

wrong ADM codes for StateProvince in some countries? #7

Open abubelinha opened 11 months ago

abubelinha commented 11 months ago

Not sure if this affects other countries, but when producing maps for Spain, I am not being able to display provinces, but autonomous communities.

Which is the source of the State/Province & Code values displayed in the Regions table? https://www.simplemappr.net/#map-regions=&tabs=5

At least for Spain, the Codes displayed in that table do not correspond to the State/Province name shown in the same row. The names correspond to a lower ADM level than the codes.

i.e. Sevilla is one of the 8 provinces in Andalucía (which is an autonomous community, corresponding to the AN code in your table), together with Huelva, Cádiz, Córdoba, Málaga, Granada, Jaén and Almería (SimpleMapper Regions table repeats the AN code for all of them, which is wrong: the code corresponds to Andalucía).

So AN does not correspond to Sevilla, Málaga ... or any of the names displayed in the table (because Andalucía is not displayed there). The table should use a different code for each Spanish State/Province name (if you want to use the ISO codes for provinces, I guess for Sevilla it should be either ES-SE or simply SE).

Thanks @abubelinha

dshorthouse commented 8 months ago

Apologies for the delay. I had subscribed to issues in my own repo! The StateProvince data come from an extraction (and use) from the shapefiles produced at https://www.naturalearthdata.com/downloads/10m-cultural-vectors/10m-admin-1-states-provinces/ and it looks like there has not been an update since June of 2022. I suggest an issue on their GitHub repo and when/if SimpleMappr updates the shapefiles, they can be reused https://github.com/nvkelso/natural-earth-vector/issues