search

dsicol / pe

0 stars 0 forks source link

Developer guide: DepositCommand Sequence Diagram bug #19

Open dsicol opened 1 year ago

dsicol commented 1 year ago

In the sequence diagram show below:

image.png

The DepositCommand does not have any X to indicate the end of the entity's life cycle. As the instance DepositCommand is invoked once each user input, there needs to be a X to indicate garbage collection, before the next instance of DepositCommand is instantiated.

nus-pe-script commented 1 year ago

Team's Response

Thank you for reporting this bug! This is the same bug at #1229 talking about the DepositCommand in the sequence diagram.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

DepositCommand is not deleted

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

image.png

as stated in your DG that DepositCommand will exist after returning value, however, it is not deleted in the sequential diagram

[original: nus-cs2113-AY2223S2/pe-interim#1672] [original labels: severity.VeryLow type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for reporting this bug. The team has accepted your bug as is!

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]