dsicol / pe

0 stars 0 forks source link

Expense not reflected in the budget list progress #9

Open dsicol opened 1 year ago

dsicol commented 1 year ago

Having a budget limit of 0.01

As shown in the image below, the academic budget category has a limit of 0.01.

image.png

Adding academic expense of 100

The academic expense has been added below as shown in the image:

image.png

However, unlike the other budgets, it is fine that the progress bar of the academic budget did not increase. However, it is still reflected that the academic budget has an expense of 0.

This information is inaccurate and misleading as users may believe that they have yet to spend any money on the academic account.

nus-se-bot commented 1 year ago

Team's Response

Yep, we agree that this is a bug based on your input, however when we tested it, we are unable to replicate the bug, as shown here

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.CannotReproduce]

Reason for disagreement: ## Bug can be recreated

image.png

Steps to recreate bug

  1. Create any budget for the current month: budget add /c foOd /a 72.25

  2. Enter budget list to review the budget added

  3. Add an expense under the budget category created for a different month: expense add /c foOd /n march foOd /a 75.25 /d 23-03-2023

  4. Enter budget list and expense list to verify the records. The expense is not be reflected in the budget list.


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** ## Severity should be `Medium` The bug arises from the fact that adding an `budget` to the current month creates the same `budget` category for all preceding months. The pro of this is that it allows users to create different expenses for the same category in all preceding months and monitor the expenses on a monthly basis. However, the con of this is that the budget `amount` for all preceding months is the same for the category created. Thus, this is highly inconvenient because: Having the same `amount` for all preceding months is confusing. Users may add an expense for the current month with a budget goal of `75.25`: ![image.png](https://raw.githubusercontent.com/dsicol/pe/main/files/0f84400d-63e7-419b-b4b5-66fca6b09684.png) However, when checking a budget in a different month like `01`, it will be confusing as the budget goal is still `75.25`, with `0` as an expense: ![image.png](https://raw.githubusercontent.com/dsicol/pe/main/files/89fe92b7-ce73-4b08-bd04-3a65cce670bc.png) This causes inconvenience as users intending to have different budget goals for `foOd` or `food` on different months will have to create a differently named category as duplicates are not allowed; to create different budget goals of different `amount`. Thus, this is not a functionality error but a feature flaw as identified. In addition, the feature flaw by definition is also "A flaw that causes occasional inconvenience to some users but they can continue to use the product." Therefore, the feature flaw specified should be of `Medium` severity.