dsifford / academic-bloggers-toolkit

WordPress plugin providing an all-in-one solution for effective academic blogging.
https://wordpress.org/plugins/academic-bloggers-toolkit/
GNU General Public License v3.0
120 stars 38 forks source link

No links? #548

Open glorious1 opened 5 years ago

glorious1 commented 5 years ago

ABT Version: 5.0.3

PHP Version: 7.2.15

Theme:GeneratePress 2.2.2

Plugin List: Honestly I've not checked this for plugin conflicts.

Browser: Firefox 65.0.1

Expected behavior:URLs or DOI appear as links in bibliography

Actual behavior: Seems that no links appear anymore

Console messages:

// Paste messages here

I'm not getting links in my references anymore since the big update, whether a URL or DOI is entered in the reference. The information doesn't appear at all, much less as a hyperlink. Is that intentional? Is it just me? Is it now necessary/possible for the format .csl to create the links instead of ABT doing it?

dsifford commented 5 years ago

Sorry for the delay in getting back with you @glorious1.

Yes, for now I had to remove the link generation feature in the last big update. I'd like to get around to figuring out how to best reimplement when I get some time though.

The reason I decided to cut it for now is because doing it in that way will generally result in non-compliant citation style formatting. (Recall that the way it was done previously was just me generating and appending a link to the end of citations if they met certain conditions).

What should be done instead is checking those conditions before generating the bibliography entry and, if a link can be generated, add it to the citation metadata so that it can be inserted into the proper location according to the citation style itself.

I'll keep this issue open for tracking, but not sure when I'll be able to get to it exactly.

glorious1 commented 5 years ago

Thanks for the reply. I don't know what the compliance requirements are about. But for now I got it to kind of work by inserting the DOI or URL in the csl style. It looks like this: Screen Shot 2019-03-14 at 8 48 46 AM

I don't know how the hyperlink gets made, if that is the csl engine or what. But I would like to do it like you did before, i.e. display a short text like URL, DOI, Source, or PDF that is hyperlinked. Problem is, if I build an anchor tag in the csl with prefix and suffix around the DOI or URL, it simply displays the anchor tag html. I've read on the csl forums there is currently no way to do that in csl.