dsifford / academic-bloggers-toolkit

WordPress plugin providing an all-in-one solution for effective academic blogging.
https://wordpress.org/plugins/academic-bloggers-toolkit/
GNU General Public License v3.0
121 stars 38 forks source link

tooltip class names should be namespaced #577

Open drhaldun opened 5 years ago

drhaldun commented 5 years ago

**ABT Version: 5.1.0

PHP Version:

**Theme: Jannah

**Expected behavior: css problem for inline citations are

**Actual behavior: tooltip is not showing when hovered on a citation

none

check this website: https://www.acilci.net/bir-seyahat-acili-jet-lag-nedir-nasil-tedavi-edilir/

dsifford commented 5 years ago

Looks like a CSS conflict in your child theme's CSS. I disabled your theme's CSS and it works fine. Not sure where the conflict lies, but that should start you in the right direction.

Closing as it's not an issue with the code here that I can fix.

alquirel commented 4 years ago

I think this issue must be solved by renaming your CSS class names to more unique words. Your class name is just "tooltip", a quite common word among coders. If you rename this into a word with a prefix, like "abt-tooltip", there will be no conflictions forever.

dsifford commented 4 years ago

This plugin leverages another library for creating the tooltips which is generates the class names.

alquirel commented 4 years ago

Thanks for reply.

I solved this problem by hard coding, I changed class names in files named "frontend.js" and "frontend.css". I believe that there must be something you can do. Otherwise I will continue to renaming by hard code to fix the issue after every update of your plugin.

dsifford commented 4 years ago

Library that was used for the tooltips had a major update somewhat recently, so maybe it was changed to allow this.

Not much time in the near future to look into this because my day job has been keeping me busy.

I'll reopen this issue nevertheless.