search

dsifford / yarn-completion

Bash completion for Yarn
MIT License
277 stars 25 forks source link

Add instructions for Debian based linux distributions #42

Open dawez opened 4 years ago

dsifford commented 4 years ago

Thanks for the PR.

Question: What is wrong with the existing instructions in the README? Installing in $BASH_COMPLETION_USER_DIR (defaulting to ~/.local/share/bash-completion) is the defacto way to install local completions for all linux OSes. This is even specified in the bash-completion README.

Did this not work for you?

dawez commented 4 years ago

Cool and thanks for your time reviewing it.

I never managed to install correctly bash-completion on my machine. So the instructions are for installing without bash-completion.

dsifford commented 4 years ago

How would this work without bash-completion installed?

Nabellaleen commented 4 years ago

On Fedora 31, according to the config file found in /etc/profile.d/bash_completion.sh, the user directory to target is ${XDG_CONFIG_HOME:-$HOME/.config}/bash_completion

dsifford commented 4 years ago

@Nabellaleen See the third "Q" in this list: https://github.com/scop/bash-completion#faq

Nabellaleen commented 4 years ago

Indeed, it works well on .local/share/bash_completion but not in .config

nolanlawson commented 4 years ago

I can confirm that the default instructions in the README did not work in Ubuntu 20.04 (threw an error: Failed writing body), whereas these instructions worked.

One extra step was required for me, though: I had to add source ~/.bash_completion to my ~/.bashrc.

(Thanks for writing this tool! :smile:)