Fix column escape in args (#47)

dsifford / yarn-completion

Bash completion for Yarn

MIT License

277 stars 25 forks source link

Fix column escape in args (#47) #48

Closed gluck closed 4 years ago

gluck commented 4 years ago

use same char escapes as npm (see npm completion output)
avoid COMP_WORDBREAKS override

gluck commented 4 years ago

(tested on ubuntu)

dsifford commented 4 years ago

@dkarlovi can you confirm this resolves your issue on macos?

dkarlovi commented 4 years ago

@dsifford I can confirm this works for me, it even doesn't inline the backslash the way mvn does in #47 so it's seamless. Great job @gluck, thank you for working on this!

I'm not on OSX though, I'm on Fedora.

dsifford commented 4 years ago

Would love to get someone who has access to OSX to confirm this still works for them because that was the specific pain point when I initially wrote the completions.

Once that happens, I'd be happy to merge this in.

dkarlovi commented 4 years ago

I've asked a few OSX people and it seems Apple doesn't ship Bash 4+ because of GPL 3. They either use zsh or Bash 3.

dsifford commented 4 years ago

Yeah, apple is locked in at bash 3. But you can still use homebrew to install modern bash and bash completions.

Those are the demographic I'd like to hear about if possible.

dsifford commented 4 years ago

Oh whoops. Forgot that I have tests for macOS already running (and passing) on this PR.

Cool, let's merge this. Thanks @gluck!