dskvr / opkg

Automatically exported from code.google.com/p/opkg
0 stars 0 forks source link

Dependency Handling Problem #49

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
As far as i understand i have found a bug in dependency handling. It
seems to me that it was taken over from ipkg.
I tried to remove a package and i got an error that the package can not
be remove because of dependencies in other packages. I looked in the
status file and found out that these dependencies are recommendations
and i started looking at the code.
The function buildDependedUponBy in pkg_depends.c generates a list of
all packages that have dependencies for the current package. But here
also suggestions and recommendatios get listed.
I attached a patch that hopefully fixes the problem in the right way, if
not tell me your suggestions.

Original issue reported on code.google.com by VulcanS...@googlemail.com on 15 Apr 2010 at 9:11

Attachments:

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
I am not sure but maybe the "count" iterator shoult be increased because the 
current
range is not correct. Just an idea.

Original comment by VulcanS...@googlemail.com on 19 Apr 2010 at 12:59

GoogleCodeExporter commented 8 years ago
I attempted to create a test case for this, but was unable to reproduce it. 
This is the test i tried:

1. Create package a, which recommends package b.
2. Create package b.
3. Install package a.
4. Install package b.
5. Remove package a.

Removal of package a was successful. Can you provide a minimal test case such 
that I can reproduce your problem?

Original comment by graham.g...@gmail.com on 8 Jun 2010 at 1:46

GoogleCodeExporter commented 8 years ago
I'm not sure how this bug would come about (or how the if statement in your 
patch can be true), as it appears to have been fixed some time ago:
http://code.google.com/p/opkg/source/detail?r=328

Original comment by graham.g...@gmail.com on 8 Jun 2010 at 2:13

GoogleCodeExporter commented 8 years ago
Ok so my problem is solved. My test case looked like yours. I can not test 
anymore, sorry.

Original comment by VulcanS...@googlemail.com on 8 Jun 2010 at 2:52

GoogleCodeExporter commented 8 years ago
Unable to reproduce. Closed at the submitter's request.

Original comment by graham.g...@gmail.com on 8 Jun 2010 at 9:40