dskvr / opkg

Automatically exported from code.google.com/p/opkg
0 stars 0 forks source link

lists_dir config line has wrong format #73

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. create a config file with a line like
lists_dir <some_path>
2. conf->lists_dir shall be set to an empty string, because in the code we set 
it to the third word in the line.
3.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?
0.1.8 on linux

Please provide any additional information below.
as of 0.1.8 i believe the opkg_conf.c:295 should be rewritten like this:
           conf->lists_dir = xstrdup(name);

Original issue reported on code.google.com by aikip...@gmail.com on 27 Jan 2011 at 9:35

GoogleCodeExporter commented 8 years ago
As it currently stands, existing conf files use the lists_dir option with, e.g.

lists_dir ext /var/lib/opkg

I agree that the second parameter is ignored, but this format is retained for 
backwards compatibility with older releases (including ipkg).

The real bug here is the lack of documentation.

Original comment by graham.g...@gmail.com on 31 Jan 2011 at 1:18

GoogleCodeExporter commented 8 years ago
Ah, ok. There is some sort of man pages i've found here. So it's even easier:)

Original comment by aikip...@gmail.com on 31 Jan 2011 at 7:56

GoogleCodeExporter commented 8 years ago
I'm picking this up as I've been digging around in the config code and the 
handling for lists_dir makes no sense. I'm going to change lists_dir to a 
normal option so the syntax will be:
    option lists_dir <some_path>

I'll write a script that can be ran when opkg is upgraded which will parse 
config files and replace the old syntax with the new.

Original comment by paul.betafive on 5 Jun 2014 at 9:55

GoogleCodeExporter commented 8 years ago
Fixed in master. The script 'utils/opkg-check-config' can be used to 
automatically replace the old syntax with the new.

Original comment by paul.betafive on 11 Jun 2014 at 8:10