dslatt / nso-icon-tool

A switch homebrew which allows you to create user icons like NSO
GNU General Public License v3.0
22 stars 4 forks source link

Translation issues #7

Closed impeeza closed 4 months ago

impeeza commented 4 months ago

Hello there, I am working on translation to Spanish (America) and found some issues which you will find on all translations:

1) The kerning for special characters is odd: image

2) On the Settings page, the screen do not scroll enough to show the Thanks section. This happen even on the en-US original file. image

3) On Checking of Updates, the message about extracting have a «... to ...» between the name of the zip and the destination folder. that «to» should be translated too image

4) If on the file hints.json I do use the character «¿» needed on Spanish for start a question like the one on "exit_hint": "¿Desea salir?", or the character «á» on the word back (atrás) the rest of the items on that file are ignored: image image

But removing that character and leaving the file:

{
  "ok": "Aceptar",
  "cancel": "Cancelar",
  "back": "Atras",
  "exit": "Salir",
  "exit_hint": "Desea salir?",
  "open": "Abrir",
  "on": "SI",
  "off": "NO",
  "delete": "Borrar",
  "save": "Guardar",
  "input": "Por favor ingrese...",
  "submit": "Guardar"
}

everything goes fine: image

image

impeeza commented 4 months ago

This are the files I am using for translating to Spanish (America) app.json hints.json

dslatt commented 4 months ago

thanks for working on that!

https://github.com/dslatt/nso-icon-tool/tree/fix/general-cleanup fixes 2/3 right now if you want to pull in it's changes

i have to spend some more time looking into borealis to see what might be causing the other problems

impeeza commented 4 months ago

Hello there, this afternoon will create a PR, Thanks a lot.

impeeza commented 4 months ago

Well I just cloned the repo and start playing with the «fix/general-cleanup» branch,

Y copied the folder resources/i18n/es-419 to the repo on that branch and build it.

The result works fine (without special characters on hints :P ) this are the issues I found, for testing the new language settings, I changed the region and language of my console and launch Homebrew Loader, on the main screen the text is fine.

On settings the «About» section is not translated:

image

image

Then the section «Check for Updates» is not translated also:

image

image

image

last the custom image «Nothing Here» is not translated yet: image

But you are on the right path, I only needed to create the es-419 folder and copy the JSON files there.

impeeza commented 4 months ago

I am just playing with the Borealis Demo and even that have trouble with special characters! (if that info worth)

dslatt commented 4 months ago

I think i figured out the font issue.

Had to update borealis so be sure to pull changes in there before you retest

2024062108310200 2024062108305900

impeeza commented 4 months ago

Wow, this night will try and let you to know.

impeeza commented 4 months ago

Well I just mad this steps:

First I cloned the repo https://github.com/dslatt/nso-icon-tool:

image

as you can see the repo is cloned and the Submodule 'library/borealis' is cloned from: (https://github.com/dslatt/borealis.git)

also I did cloned the repo https://github.com/dslatt/borealis.git and compare the folders ~/borealis and ~/nso-icon-tool/library/borealis and some files are different:

image

the .git are normal because the right one is a submodule, but is strange the files application.cpp & switch_font.cpp should be the latest version on both folders, so I copied the new ones on the nso-icon-tool cloned repo.

Then I copied the es-419 to ~/nso-icon-tool/resources/i18n with "¿Desea salir?", and "Atrás" on the hints.json file, then build the app:

image

The kerning problem is gone, and the special characters also are shown for hints.json file, about that I think I was using the wrong encoding, sorry for that. image

~Still the About update, extracted and Nothing here sections are not translated, I think the code is not internationalized yet.~ I found the problem, I missed a «,» after "overwrite": and before "about", again my bad!

I think you are on the right path, thanks a lot for all your help.

impeeza commented 4 months ago

Created https://github.com/dslatt/nso-icon-tool/pull/14 to update files