search

dsmelov / simsim

Use SimSim to explore iOS application folders in Terminal or Finder. Fast, stable, free alternative to SimPholders.
MIT License
1.47k stars 95 forks source link

Add support for Realm Studio #26

Closed humblehacker closed 6 years ago

humblehacker commented 6 years ago

Thanks for building this useful utility. I use it all the time.

This PR adds an additional menu item for Realm Studio. Please let me know if you'd like this structured differently, such as a single Realm module that handles both Browser and Studio.

One change I'd like to make would be to not show the "Install Realm ..." menu item once one of the two applications is installed. Let me know if you agree, and I'll update my PR.

I also took the liberty of updating the brace style of the existing Realm Browser code to match the rest of the application, and to use NS_ASSUME_NONNULL in the relevant headers. Let me know if any of these changes are not desireable, and I'll revert them.

DesmanLead commented 6 years ago

@humblehacker

One change I'd like to make would be to not show the "Install Realm ..." menu item once one of the two applications is installed. Let me know if you agree, and I'll update my PR.

Sure, it makes sense.

@humblehacker @dsmelov BTW, does anyone still use Realm Browser? Maybe we can consider dropping Realm Browser support?

jesuslg123 commented 6 years ago

Hi,

I'm still using it, please don't drop it, any extra feature will be loved

El 27 feb 2018, a las 15:14, Artem K. notifications@github.com escribió:

@humblehacker

One change I'd like to make would be to not show the "Install Realm ..." menu item once one of the two applications is installed. Let me know if you agree, and I'll update my PR.

Sure, it makes sense.

@humblehacker @dsmelov BTW, does anyone still use Realm Browser? Maybe we can consider dropping Realm Browser support?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

DesmanLead commented 6 years ago

I see. So we are going to support both.

@jesuslg123 thanks for the feedback!

@humblehacker

Please let me know if you'd like this structured differently, such as a single Realm module that handles both Browser and Studio.

AppDelegate should definitely use a single Realm module interface. The AppDelegate is already overloaded so I don't think managing different Realm apps there is a good idea. But you can introduce some kind of submodules which implement single app support. So we will have a Ream module with Realm Browser and Realm Studio submodules.