Open ernstaii opened 2 months ago
I would prefer simply giving cell with weight another background color. Preferably a darker variant of the existing cell color. You would then be able see if the cell has a weight or not. That would meet your requirement.
There are two reasons I prefer not to use the idea of a colored bar:
I you agree I can make an update next weekend.
Here's an example (at the minimum zoom level) where the bar represents quantiles of 10%. Even dependency weight 1 is visible and the bar is full for the top 10%. This scales nicely with what the matrix currently displays. The exact number is still visible in the cell and of course in the tooltip. Granted, the black bar is a bit intense, but dark grey would also work.
And here's a version where the cells themselves are darkened (binary, independent of actual weight). The disadvantages I see here are
Here's the bar again with dark grey instead of black. Looks better, IMHO.
Thanks for all effort put in the 4 pull requests. Currently not having much time available. Will look into these when I have some time.
I you have other feedback on the usage of the tool please let me know. I see you added TODO in the code.
When zooming out for a big DSM, cell weight are not readable anymore. Cells with and those without weights are not easily distinguishable. I suggest to change the cell visualisation so the lower half of the cell is a coloured bar (themed, set to black) that grows with the weight of the cell. This way, the user quickly sees which cells contain a dependency even when the cells are very small. Do you want a PR for this?