dsnallfot / LoopFollowiAPS

A general Follow app for parents of T1D Loop Users
GNU Affero General Public License v3.0
3 stars 0 forks source link

Add send meal+bolus possibility to Meal view? #26

Closed dsnallfot closed 7 months ago

dsnallfot commented 7 months ago

Idea to enable an even smoother workflow when registering remote meals:

Edit: Added checkboxes for what I’ve testing so far in mealbolus branch

Basic functionality

Bolus calculator/recommendations

Other

dsnallfot commented 7 months ago

Some screenshots from a testing branch (work in progress and sorry for some Swedish text).

Yes, this is working right now (but the bolus amount is not yet connected to any CR or other calculations. Just maxBolus guardrai)l. And FaceID gets enabled as a second confirmation step if any bolus amount larger than 0 is entered and send button is clicked (otherwise, when only sending carbs, only one confirmation yes/cancel is shown)

Dark mode Light mode Max Bolus exceeded Max Carbs exceeded
Simulator Screenshot - iPhone 13 - 2024-03-26 at 22 18 58 Simulator Screenshot - iPhone 13 - 2024-03-26 at 22 19 07 Simulator Screenshot - iPhone 13 - 2024-03-26 at 22 19 38 Simulator Screenshot - iPhone 13 - 2024-03-26 at 22 19 53
Confirmation without bolus Confirmation with bolus step 1 Confirmation with bolus step 2 Textstring generated
Simulator Screenshot - iPhone 13 - 2024-03-26 at 22 19 30 Simulator Screenshot - iPhone 13 - 2024-03-26 at 22 19 19 Simulator Screenshot - iPhone 13 - 2024-03-26 at 22 20 29 Simulator Screenshot - iPhone 13 - 2024-03-26 at 22 20 45
dsnallfot commented 7 months ago
Send button when no Bolus is entered Send button when bolus is entered
Simulator Screenshot - iPhone 13 - 2024-03-27 at 00 16 48 Simulator Screenshot - iPhone 13 - 2024-03-27 at 00 16 44

Swedish "Skicka Måltid och Bolus" = "Send Meal and Bolus"

dsnallfot commented 7 months ago
Remote view Bolus visible Bolus hidden Meal view bolus visible Bolus hidden Hide setting
Simulator Screenshot - iPhone 13 - 2024-03-27 at 01 53 29 Simulator Screenshot - iPhone 13 - 2024-03-27 at 01 57 20 Simulator Screenshot - iPhone 13 - 2024-03-27 at 01 53 34 Simulator Screenshot - iPhone 13 - 2024-03-27 at 01 57 26 Simulator Screenshot - iPhone 13 - 2024-03-27 at 01 57 48

Need to figure out a way to show/hide bolus button in Remote Main View without force closing/restarting the app (to reload and read the latest on/off setting to memory).

dsnallfot commented 7 months ago

Slightly unrelated, but I will also make the custom action button possible to show/hide in settings in the same manner

dsnallfot commented 7 months ago

Hide custom actions switch added.

Below are all possible combinations of buttons on the remote main screen. Bolus and custom actions ("Förval" in this Swedish version) shows/hides with switches in settings

All buttons Hide custom Hide bolus Hide custom & bolus
Simulator Screenshot - iPhone 13 - 2024-03-27 at 09 44 58 Simulator Screenshot - iPhone 13 - 2024-03-27 at 09 41 03 Simulator Screenshot - iPhone 13 - 2024-03-27 at 09 44 05 Simulator Screenshot - iPhone 13 - 2024-03-27 at 09 38 39

Settings

Hide custom Hide bolus Hide custom & bolus
Simulator Screenshot - iPhone 13 - 2024-03-27 at 09 40 20 Simulator Screenshot - iPhone 13 - 2024-03-27 at 09 40 33 Simulator Screenshot - iPhone 13 - 2024-03-27 at 09 40 39
aug0211 commented 7 months ago

Love these - my intuition would be to "flip" these show/hide toggles for the advanced functions. The reasoning here is I would think of the advanced features being "off" or "disabled" by default. I'd have the switches match that, to show "off" as the default state, and require the user to enable them by flipping them "on" or "enabled".

This would mean renaming the switches to something like "Show Bolus Actions" and "Show Custom Actions" and having them set to off by default.

Curious for your thoughts on this.

dsnallfot commented 7 months ago

I totally agree on the intuition logic. The only reason "hide" is on is that I did not want to reverse all code since it's used in several places. But that is something we should do. agree

dsnallfot commented 7 months ago

Love these - my intuition would be to "flip" these show/hide toggles for the advanced functions. The reasoning here is I would think of the advanced features being "off" or "disabled" by default. I'd have the switches match that, to show "off" as the default state, and require the user to enable them by flipping them "on" or "enabled".

This would mean renaming the switches to something like "Show Bolus Actions" and "Show Custom Actions" and having them set to off by default.

Curious for your thoughts on this.

Buttons fixed in PR #41 now. 😊

dsnallfot commented 7 months ago

CLosing this since bolus now is implemented in meal view.

Create new issue for the Bolus Calculator stuff (could be a big undertaking and maybe not in scope in the near future)