dsnallfot / LoopFollowiAPS

A general Follow app for parents of T1D Loop Users
GNU Affero General Public License v3.0
3 stars 0 forks source link

Lots of new features and improvements (Meal Bolus, Custom Actions and more) #32

Closed dsnallfot closed 7 months ago

dsnallfot commented 7 months ago

See issues #18 #26 #27 for lots of screenshots and more reasoning

In short:

Remote bolus + meals

Custom Actions

Settings

Known issue (workaround exists)

dsnallfot commented 7 months ago
Old buttons New buttons
Skärmavbild 2024-03-28 kl  09 05 53 Skärmavbild 2024-03-28 kl  09 05 37
aug0211 commented 7 months ago

Very nice! Approving and merging!

I personally like the more traditional button options with the green sliders :) That is a matter of personal preference though probably. The gray options look more like sub-menu selections to me than on/off switches.

We can look at the "Alarms" tab in LoopFollow as an example, actually. It uses the gray tappable view for things like "Urgent Low" or "Low" or High" and these are actually more like sub-menu selections, that load the alarm detail screens down below it.

Then for the on/off switches, the traditional toggle is used.

I left comments on the wording/phrasing and potentially reversing (default = off) the logic for the advanced features (bolus) in settings as well - separate issue.

dsnallfot commented 7 months ago

Yeah, as mentioned in the other issue I agree with you that the show/hide should be reversed. This was a test to just change the buttons to segment buttons instead of reversing the code logic. But Lets bring back the buttons and make Show Bolus/Custom Actions the on-state. Its on the todo list now