search

dsnallfot / LoopFollowiAPS

A general Follow app for parents of T1D Loop Users
GNU Affero General Public License v3.0
3 stars 0 forks source link

Fix double tap meal bug #42

Closed dsnallfot closed 7 months ago

dsnallfot commented 7 months ago

by disabling send button from first confirmation yes/cancel to last confirmation if message was succesfully delivered or failed. Enable button again when reloading view or if Twilio reports back an http error (to be able to try again)

Solution for bug #25

Message success

https://github.com/dsnallfot/LoopFollowiAPS/assets/72826201/0dc40880-aafe-44c4-b47b-1fae2d2c2e58

Message failure

https://github.com/dsnallfot/LoopFollowiAPS/assets/72826201/84edb0f7-d55d-4307-bfd6-99def6b443ac

dsnallfot commented 7 months ago

We should probably build the same deactivate send-button functionality for bolus, override, temp target and custom actions view also to be consistent. But fixing this for meal view first now (and for meal view I already had a @IBOutlet connection to the button = Not screwing up anything in the main.storyboard where you're working on the constraints etc.

To add the same disable send button functionality for the other views new @IBOutlet needs to be added for each button (easy job, but affects main.storyboard)

Edit: Have prepared and tested the changes for all Remote views in my Special branch, but will keep it there until main-storyboard is cleaned up in dev-remote so I don't mess anything up