dsoares / roundcube-lastlogin

Roundcube plugin to save and show user login information and login history.
GNU General Public License v3.0
16 stars 12 forks source link

uncompatible and not portable, (not postgresql or sqlite due close mysql querys) #1

Closed mckaygerhard closed 8 years ago

mckaygerhard commented 8 years ago

in the functions "lasst_log" and "write_log" does not use query with the RC api

and in any way the query are not SQL standar so this plugins that its a great feature does not are usefully wuith real DBMS like oracle, postgresql or sybase using odbc or pgpsql drivers

]I can made some pull request to fixed that important topis

dsoares commented 8 years ago

I've pushed to master some changes to make the SQL queries more SQL standard.

i made yesterday some fine tune and table creation are not necesary if used a own made log file, that made more portable and better using egrep and shell scripts (roundcube have many shell scripts in bin directory)

I don't see the point of using a file, since there is already a userlogins log file created by Roundcube (see program/include/rcmail.php). I created the table because i need it for other scripts i implemented (very specific to my organization) that do a bunch of SQL queries.

UNIX_TIMESTAMP(field) returns the field value in seconds since '1970-01-01 00:00:00' UTC as an unsigned integer. I've translated it to sqlite and postgresql. You are welcome to contribute with those drivers initial setup scripts.

As i said in #2 $rows[] = $res is compatible with PHP 5.3.

mckaygerhard commented 8 years ago

i made a pull request to have inital script of postgres

thanks for the commit solves the problem of location human visualization for users when are loged!