Fixed library finding for other platforms/package managers.

dsoprea / PyEasyArchive

A very intuitive and useful adapter to libarchive for universal archive access.

MIT License

96 stars 33 forks source link

Fixed library finding for other platforms/package managers. #32

Open ajsyp opened 5 years ago

ajsyp commented 5 years ago

libarchive.so is called archive.dll on Windows, which means that ctypes.util.find_library won't find libarchive on Windows. This PR calls find_library on archive if libarchive didn't work, thereby making this package function correctly on Windows.

ajsyp commented 5 years ago

It should be mentioned that this is very similar to #30, but allows for libarchive to be used, as well.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 18

5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 70.719%

Totals
Change from base Build 14:	0.2%
Covered Lines:	669
Relevant Lines:	946

💛 - Coveralls

ajsyp commented 5 years ago

Changes made. Let me know if there's anything else!

ajsyp commented 5 years ago

Just a friendly check -- is there anything else needed before merging?

amstelchen commented 2 months ago

@dsoprea Any plans to merge this?