dsoprea / PyEasyArchive

A very intuitive and useful adapter to libarchive for universal archive access.
MIT License
96 stars 33 forks source link

Add support for reading and writing encrypted archives with test suites #45

Open udgover opened 4 years ago

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 50


Changes Missing Coverage Covered Lines Changed/Added Lines %
libarchive/adapters/archive_read.py 11 14 78.57%
libarchive/adapters/archive_write.py 15 21 71.43%
<!-- Total: 43 52 82.69% -->
Totals Coverage Status
Change from base Build 47: 0.5%
Covered Lines: 708
Relevant Lines: 991

💛 - Coveralls
udgover commented 4 years ago

I found the issue with Python 2.7, it's related to a call to bytes which works perfectly with Python3 but not Python2. Do I need to add version check to call the right function depending on Py2 or Py3? Do you still want to support Python2.7?

Based on your feedback, I'll commit the patch.

udgover commented 4 years ago

Sorry for the previous commit which only fixed python2 and not python3. Now all tests are green!

udgover commented 4 years ago

Did you have time to check this PR?

udgover commented 4 years ago

Hello,

Any news to review this PR?