Trees don't follow symlink unless explicitly enabled

dsoprea / PyInotify

An efficient and elegant inotify (Linux filesystem activity monitor) library for Python. Python 2 and 3 compatible.

GNU General Public License v2.0

242 stars 73 forks source link

Trees don't follow symlink unless explicitly enabled #109

Open uellue opened 10 months ago

uellue commented 10 months ago

Watching a tree containing a symlink to '/' adds a watch to the whole file system, which is probably unwanted. To avoid such behavior by default, following symlinks has to be enabled explicitly. The code may still be vulnerable to TOCTOU.

Further changes:

Use os.walk() to traverse the tree to watch
Remove duplicate add_watch() for IN_MOVED_TO
flake8
Warn instead of failing hard if adding a watch in a tree fails. Can be, for example, a permission error.

uellue commented 10 months ago

About the older Python versions: Are they still relevant?