search

dsoprea / PyInotify

An efficient and elegant inotify (Linux filesystem activity monitor) library for Python. Python 2 and 3 compatible.
GNU General Public License v2.0
245 stars 73 forks source link

python 3 compatibility #12

Closed baszoetekouw closed 8 years ago

baszoetekouw commented 8 years ago

These changes are necessary to make the lib work with python 3.5. I think these changes should be fine for python 2, but I haven't tested that explicitly.

baszoetekouw commented 8 years ago

And, and of course only now I notice pull request #11 by @jackstanek . Our solutions are marginally different; I would argue that it is up to the user to encode and decode the paths and filenames, as there is no (easy) way for the library to know the encoding of the filesystem,

dsoprea commented 8 years ago

I agree with the reasoning, though you win because I would've had to wait on another change that I had yet to mention to him, anyway. Thanks for contributing.