For renames, Drop the entry and re-add with the new name.

dsoprea / PyInotify

An efficient and elegant inotify (Linux filesystem activity monitor) library for Python. Python 2 and 3 compatible.

GNU General Public License v2.0

245 stars 73 forks source link

For renames, Drop the entry and re-add with the new name. #32

Closed mie00 closed 6 years ago

dsoprea commented 6 years ago

Thanks for this. There's currently a merge conflict as simple moved-from and moved-to events are now being handled, but I'm also not convinced that cookies really offer any value. Do you perceive a downside to just sticking with naive deregistration with the moved-from events and reregistrations with the moved-to events, with no awareness of cookies?

mie00 commented 6 years ago

This was a quick fix a year ago. Simple handling for the events is better. Closing.

dsoprea commented 6 years ago

Thanks.