search

dsoprea / PyInotify

An efficient and elegant inotify (Linux filesystem activity monitor) library for Python. Python 2 and 3 compatible.
GNU General Public License v2.0
245 stars 73 forks source link

[datadog][select-fixes] epoll -> poll + nonblocking reads #52

Closed peterashwell closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.1%) to 84.752% when pulling 3b823a7d4b3f44801af4b27a5b848ab66da960b5 on DataDog:datadog into 78670d829ba363dcdde814513990e31e0e8eb7b7 on dsoprea:master.

dsoprea commented 6 years ago

What's the deal with these two PRs (#52, #53)?

peterashwell commented 6 years ago

Sorry for the spam. I meant to open both of these PRs against the fork but apparently github's UI is too much for me.

The intention of the PRs is to make the library gevent compatible by using poll instead of epoll, and also to fix a forever blocking os.read() we have seen.

On Sat, Jul 7, 2018 at 4:08 AM, Dustin Oprea notifications@github.com wrote:

What's the deal with these two PRs (#52 https://github.com/dsoprea/PyInotify/pull/52, #53 https://github.com/dsoprea/PyInotify/pull/53)?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/dsoprea/PyInotify/pull/52#issuecomment-403197706, or mute the thread https://github.com/notifications/unsubscribe-auth/AAo7p8Jtw942mi__wmO2w-ppl-7JuTyOks5uEGyHgaJpZM4VFsZD .

dsoprea commented 6 years ago

I'd really like to see that in mainline. I didn't actually realize that inotify could be used with gevent.

Think about reopening a PR. It seemed straightforward and this might get you back on mainline.

On Sat, Jul 7, 2018, 16:52 Peter Ashwell notifications@github.com wrote:

Sorry for the spam. I meant to open both of these PRs against the fork but apparently github's UI is too much for me.

The intention of the PRs is to make the library gevent compatible by using poll instead of epoll, and also to fix a forever blocking os.read() we have seen.

On Sat, Jul 7, 2018 at 4:08 AM, Dustin Oprea notifications@github.com wrote:

What's the deal with these two PRs (#52 https://github.com/dsoprea/PyInotify/pull/52, #53 https://github.com/dsoprea/PyInotify/pull/53)?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/dsoprea/PyInotify/pull/52#issuecomment-403197706, or mute the thread < https://github.com/notifications/unsubscribe-auth/AAo7p8Jtw942mi__wmO2w-ppl-7JuTyOks5uEGyHgaJpZM4VFsZD

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dsoprea/PyInotify/pull/52#issuecomment-403242191, or mute the thread https://github.com/notifications/unsubscribe-auth/AArrakpsqNbMeaXasoZAXFgKKRDJW0Qhks5uER-HgaJpZM4VFsZD .