search

dsoprea / PyInotify

An efficient and elegant inotify (Linux filesystem activity monitor) library for Python. Python 2 and 3 compatible.
GNU General Public License v2.0
242 stars 73 forks source link

Fix for issue #66, removing 'nose' as a production requirement. #74

Closed dwvisser closed 4 years ago

dwvisser commented 5 years ago

This fixes the issue #66 where nose is getting installed automatically when someone invokes pip install inotify. Instead, it places nose in the test dependencies and setuptools test runner target.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 85.069% when pulling 115a170a2cea6cb91cc902e3636478561509067a on dwvisser:IssueFix-66-NoNoseInProduction into 288a2b01fd4a726dc68d960f8351630aee788a13 on dsoprea:master.

skonakov-tophat commented 4 years ago

Running into the same issue, would be awesome to get this pr merged :)

dsoprea commented 4 years ago

I'll merge it if you can provide a URL that explains how and where those testing-dependencies are installed if not in the general requirements.

nehaljwani commented 4 years ago

I'll merge it if you can provide a URL that explains how and where those testing-dependencies are installed if not in the general requirements.

From https://setuptools.readthedocs.io/en/stable/setuptools.html:

tests_require If your project’s tests need one or more additional packages besides those needed to install it, you can use this option to specify them. It should be a string or list of strings specifying what other distributions need to be present for the package’s tests to run. When you run the test command, setuptools will attempt to obtain these (even going so far as to download them using EasyInstall). Note that these required projects will not be installed on the system where the tests are run, but only downloaded to the project’s setup directory if they’re not already installed locally.

So, basically if you run: python setup.py test, the test requirements will be downloaded and installed.